fix(cdk/tree): fix issue where isExpanded wouldn't be set if placed before isExpandable
#29565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… before `isExpandable`
BobobUnicorn
requested review from
crisbeto and
andrewseguin
and removed request for
a team
andrewseguin
approved these changes
Aug 9, 2024
andrewseguin
added
action: merge
andrewseguin
approved these changes
Aug 9, 2024
crisbeto
approved these changes
Aug 13, 2024
|
Is this fix only applicable to version 19? Why not include it in version 18.2? |
crisbeto
pushed a commit
to crisbeto/material2
that referenced
this pull request
Aug 27, 2024
… before `isExpandable` (angular#29565) * fix(cdk/tree): fix issue where `isExpanded` wouldn't be set if placed before `isExpandable` * fix(cdk/tree): actually fix the issue * fix(cdk/tree): actually actually fix tests
|
I've sent #29647 to port it to the patch branch. |
crisbeto
added a commit
that referenced
this pull request
Aug 27, 2024
… before `isExpandable` (#29565) (#29647) * fix(cdk/tree): fix issue where `isExpanded` wouldn't be set if placed before `isExpandable` * fix(cdk/tree): actually fix the issue * fix(cdk/tree): actually actually fix tests Co-authored-by: Cassandra Choi <[email protected]>
This was referenced Sep 19, 2024
This was referenced Sep 24, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.