fix(cdk/drag-drop): reset pointer events on descendants #29370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
G
crisbeto
requested review from
amysorto,
mmalerba and
andrewseguin
and removed request for
a team
crisbeto
force-pushed
the
tabs-drag-drop-fixes
branch
from
109bc19
to
17a9668
Compare
When we create the preview and placeholder, we set `pointer-events: none` on them so they don't interfere with the `elementFromPoint` calls, however descendants of the element could be resetting it back to `auto` for themselves. These changes update the reset to prevent it from happening.
crisbeto
force-pushed
the
tabs-drag-drop-fixes
branch
from
17a9668
to
f6c6f2e
Compare
crisbeto
changed the title
crisbeto
removed
the
merge: preserve commits
amysorto
approved these changes
Jul 3, 2024
crisbeto
added a commit
that referenced
this pull request
Jul 4, 2024
When we create the preview and placeholder, we set `pointer-events: none` on them so they don't interfere with the `elementFromPoint` calls, however descendants of the element could be resetting it back to `auto` for themselves. These changes update the reset to prevent it from happening. (cherry picked from commit bfa3ac5)
crisbeto
added a commit
that referenced
this pull request
Jul 4, 2024
When we create the preview and placeholder, we set `pointer-events: none` on them so they don't interfere with the `elementFromPoint` calls, however descendants of the element could be resetting it back to `auto` for themselves. These changes update the reset to prevent it from happening. (cherry picked from commit bfa3ac5)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we create the preview and placeholder, we set
pointer-events: noneon them so they don't interfere with theelementFromPointcalls, however descendants of the element could be resetting it back toautofor themselves. These changes update the reset to prevent it from happening.