Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk/listbox): unable to tab in if active option is removed #28583

Merged
merged 1 commit into from
Feb 13, 2024
Merged

fix(cdk/listbox): unable to tab in if active option is removed #28583

merged 1 commit into from
Feb 13, 2024

Conversation

crisbeto
Copy link
Member

Fixes that the listbox didn't allow focus back in when its active option is removed.

Fixes #28557.

@crisbeto
fix(cdk/listbox): unable to tab in if active option is removed
298003e 
Fixes that the listbox didn't allow focus back in when its active option is removed.

Fixes angular#28557.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Feb 13, 2024
@crisbeto crisbeto requested a review from jelbourn as a code owner February 13, 2024 10:18
mmalerba
mmalerba approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Feb 13, 2024
@crisbeto crisbeto merged commit d766b14 into angular:main Feb 13, 2024
24 of 27 checks passed
crisbeto added a commit that referenced this pull request Feb 13, 2024
@crisbeto
fix(cdk/listbox): unable to tab in if active option is removed (#28583)
55eeee3 
Fixes that the listbox didn't allow focus back in when its active option is removed.

Fixes #28557.

(cherry picked from commit d766b14)
crisbeto added a commit that referenced this pull request Feb 13, 2024
@crisbeto
fix(cdk/listbox): unable to tab in if active option is removed (#28583)
1a9e076 
Fixes that the listbox didn't allow focus back in when its active option is removed.

Fixes #28557.

(cherry picked from commit d766b14)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(CdkListbox): List is not reachable via keyboard after options change
2 participants
@crisbeto @mmalerba