Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/tabs): nav bar not navigating on enter presses #27862

Merged
merged 1 commit into from
Sep 29, 2023
Merged

fix(material/tabs): nav bar not navigating on enter presses #27862

merged 1 commit into from
Sep 29, 2023

Conversation

crisbeto
Copy link
Member

Fixes that the tab nav bar wasn't navigating when pressing the enter key.

Fixes #27843.

@crisbeto
fix(material/tabs): nav bar not navigating on enter presses
c9e154c 
Fixes that the tab nav bar wasn't navigating when pressing the enter key.

Fixes angular#27843.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Sep 28, 2023
@crisbeto crisbeto requested a review from zarend September 28, 2023 08:51
@crisbeto crisbeto mentioned this pull request Sep 28, 2023
Closed
1 task
@crisbeto crisbeto added the Accessibility This issue is related to accessibility (a11y) label Sep 28, 2023
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Sep 29, 2023
@crisbeto crisbeto merged commit 5dd614a into angular:main Sep 29, 2023
20 checks passed
crisbeto added a commit that referenced this pull request Sep 29, 2023
@crisbeto
fix(material/tabs): nav bar not navigating on enter presses (#27862)
fd97395 
Fixes that the tab nav bar wasn't navigating when pressing the enter key.

Fixes #27843.

(cherry picked from commit 5dd614a)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@zarend zarend Awaiting requested review from zarend

@wagnermaciel wagnermaciel Awaiting requested review from wagnermaciel

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(tabs): mat-tab-nav-bar tab working with space but not with enter key
2 participants
@crisbeto @mmalerba