Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(material/slider): clarify behavior of slider range thumbs #27846

Merged
merged 4 commits into from
Sep 26, 2023
Merged

docs(material/slider): clarify behavior of slider range thumbs #27846

merged 4 commits into from
Sep 26, 2023

Conversation

stephanietuerk
Copy link
Contributor

Clarifies possible behavior/values of matStartThumb and matEndThumb in slider component 'Selecting a range' documentation.

Addresses #27837

@stephanietuerk
docs(material/slider): clarify behavior of slider range thumbs
d3068f2 
Clarifies possible behavior/values of matStartThumb and matEndThumb in
slider component 'Selecting a range' documentation.

Addresses angular#27837
@angular-robot angular-robot bot added the area: docs Related to the documentation label Sep 25, 2023
wagnermaciel
wagnermaciel reviewed Sep 26, 2023
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error wasn't from you but since we're here, matStartThumb should be matSliderStartThumb. Same for matEndThumb

wagnermaciel
wagnermaciel approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wagnermaciel wagnermaciel added the target: patch This PR is targeted for the next patch release label Sep 26, 2023
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Sep 26, 2023
@mmalerba mmalerba removed the request for review from devversion September 26, 2023 20:20
@mmalerba mmalerba added the merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed label Sep 26, 2023
@mmalerba mmalerba merged commit 891e3a0 into angular:main Sep 26, 2023
mmalerba pushed a commit that referenced this pull request Sep 26, 2023
@stephanietuerk @mmalerba
docs(material/slider): clarify behavior of slider range thumbs (#27846)
038fefe 
* docs(material/slider): clarify behavior of slider range thumbs

Clarifies possible behavior/values of matStartThumb and matEndThumb in
slider component 'Selecting a range' documentation.

Addresses #27837

* correct names of slider thumbs and streamline language

* small wording update for clarity

* add 'the' in front of reference to thumb

(cherry picked from commit 891e3a0)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephanietuerk @wagnermaciel @mmalerba