Switch the CDK to input transforms #27778
Conversation
Switches inputs in cdk/a11y to use transforms instead of getters/setters.
Switches inputs in cdk/accordion to use transforms instead of getters/setters.
Switches inputs in cdk/drag-drop to use transforms instead of getters/setters.
Switches inputs in cdk/listbox to use transforms instead of getters/setters.
crisbeto
added
P3
crisbeto
requested review from
mmalerba,
andrewseguin,
jelbourn,
devversion and
josephperrott
as code owners
crisbeto
changed the title
crisbeto
force-pushed
the
cdk-input-transforms
branch
from
36dc52c to
44e6460
Compare
Switches inputs in cdk/menu to use transforms instead of getters/setters.
Switches inputs in cdk/observers to use transforms instead of getters/setters.
Switches inputs in cdk/a11y to use transforms instead of getters/setters.
Switches inputs in cdk/scrolling to use transforms instead of getters/setters.
Switches inputs in cdk/stepper to use transforms instead of getters/setters.
Switches inputs in cdk/table to use transforms instead of getters/setters.
Switches inputs in cdk/text-field to use transforms instead of getters/setters.
crisbeto
force-pushed
the
cdk-input-transforms
branch
from
44e6460 to
83c3fa8
Compare
There was a problem hiding this comment.
LGTM but I think we should reach consensus on https://angular-team.slack.com/archives/C040TF8UT/p1694087146008889 sooner than later- because we are clearly opening up the types to anything with a PR like this
|
+1 @devversion Would be good to get this clarified before the release Also - we should mark the current coercion functions as deprecated so that we can remove them in v19 |
|
We discussed this today during standup. I'll merge this PR and work on making the typings stronger on the FW side before v17. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Reworks most of the places where we use input coercion in the CDK to input transforms.