Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk/menu): run change detection for changes to overlay ref of trigger #27726

Merged
merged 1 commit into from
Sep 4, 2023
Merged

fix(cdk/menu): run change detection for changes to overlay ref of trigger #27726

merged 1 commit into from
Sep 4, 2023

Conversation

sbarfurth
Copy link
Contributor

Fixes an issue where menu triggers placed inside components using OnPush change detection would not have their aria-expanded property updated correctly when switching between sibling triggers.

Fixes #27725

@sbarfurth
fix(cdk/menu): run change detection for changes to overlay ref of tri…
7e1e6a5 
…gger

Fixes an issue where menu triggers placed inside components using OnPush change detection
would not have their `aria-expanded` property updated correctly when switching between
sibling triggers.

Fixes angular#27725
mmalerba
mmalerba approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Aug 29, 2023
@crisbeto crisbeto self-assigned this Sep 4, 2023
@crisbeto crisbeto merged commit 8eb494e into angular:main Sep 4, 2023
crisbeto pushed a commit that referenced this pull request Sep 4, 2023
@sbarfurth @crisbeto
fix(cdk/menu): run change detection for changes to overlay ref of tri…
08dd232 
…gger (#27726)

Fixes an issue where menu triggers placed inside components using OnPush change detection
would not have their `aria-expanded` property updated correctly when switching between
sibling triggers.

Fixes #27725

(cherry picked from commit 8eb494e)
@sbarfurth sbarfurth deleted the detect-changes-in-cdk-menu-trigger branch September 4, 2023 11:20
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(cdk/menu): Trigger does not update ARIA values correctly in OnPush components
3 participants
@sbarfurth @mmalerba @crisbeto