fix(cdk/tree): CdkTreeNodeToggle focuses node when toggling it #27631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarend
added
Accessibility
|
Deployed dev-app for 6e83d60 to: https://ng-dev-previews-comp--pr-angular-components-27631-ie7ahebi.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
BobobUnicorn
approved these changes
Aug 15, 2023
zarend
force-pushed
the
cdk-tree-revamp-focus-on-expand-collapse
branch
from
6e83d60
to
d8c8fd9
Compare
zarend
force-pushed
the
cdk-tree-revamp
branch
from
e65f49a
to
3665278
Compare
Fix focus behavior of CdkTreeNodeToggle. When toggling the expanded or collapsed state of a node, focus that node. Fix issue where end user cannot tab into tree component when collaping the parent of the active node. Before this commit is applied, there is a bug where end user cannot tab into the tree. Reproduction steps 1. Active a tree node 2. (focus state renders) 3. Using mouse, collapse parent of node from step 1. 4. (tree node collapses) 5. Press Tab, then shift + tab 6. (item before tree is focused. Can tab into the tree) With this commit applied, above issue is no longer expected to reproduce. This commit message is only for reviewers of this PR and can be deleted when landing this change in main.
zarend
force-pushed
the
cdk-tree-revamp-focus-on-expand-collapse
branch
from
d8c8fd9
to
e8377b8
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix focus behavior of CdkTreeNodeToggle. When toggling the expanded or collapsed state of a node, focus that node. Fix issue where end user cannot tab into tree component when collaping the parent of the active node.
Before this commit is applied, there is a bug where end user cannot tab into the tree.
Reproduction steps
With this commit applied, above issue is no longer expected to reproduce.
This commit message is only for reviewers of this PR and can be deleted when landing this change in main.