Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk/scrolling): adds ngTemplateContextGuard #27276

Merged
merged 2 commits into from
Sep 2, 2024
Merged

fix(cdk/scrolling): adds ngTemplateContextGuard #27276

merged 2 commits into from
Sep 2, 2024

Conversation

naaajii
Copy link
Contributor

@naaajii naaajii commented Jun 11, 2023

implements ngTemplateContextGuard for
CdkVirtualForOf directive

fixes #26609

@naaajii
fix(cdk/scrolling): adds ngTemplateContextGuard
3635e9e 
implements ngTemplateContextGuard for CdkVirtualForOf directive

fixes angular#26609
crisbeto
crisbeto approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM, but this is a breaking change so it'll have to wait until v17.

@crisbeto crisbeto added this to the 17.0.0 milestone Jun 12, 2023
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release labels Jun 12, 2023
@crisbeto
Copy link
Member

Caretaker note: the stronger typings cause a lot of broken builds internally.

@mmalerba mmalerba self-assigned this Jun 14, 2023
@mmalerba mmalerba removed this from the 17.0.0 milestone Oct 19, 2023
@mmalerba mmalerba removed their assignment Jan 9, 2024
@studioromeo
Copy link

Hello. I just wanted to ask what the new milestone is for this PR since v17 has been released. Thanks!

@JorisMolnar
Copy link

I would like to repeat the question. This PR currently has no milestone. Are you planning on merging this for some major version?

@crisbeto
Copy link
Member

We do want to merge it eventually, but we haven't had the bandwidth to debug the breakages internally. An option can be to patch out these changes internally so it can at least land externally.

@crisbeto crisbeto added merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed and removed merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Sep 2, 2024
@crisbeto crisbeto removed the request for review from andrewseguin September 2, 2024 08:12
@crisbeto crisbeto merged commit 5439460 into angular:main Sep 2, 2024
3 of 5 checks passed
@naaajii naaajii deleted the fix-26609 branch September 27, 2024 18:29
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(cdk/scrolling): improve template type checking for CdkVirtualForOf Directive
5 participants
@naaajii @crisbeto @studioromeo @JorisMolnar @mmalerba