Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dialog): use injector from viewContainerRef if provided #2655

Merged
merged 1 commit into from
Jan 19, 2017
Merged

fix(dialog): use injector from viewContainerRef if provided #2655

merged 1 commit into from
Jan 19, 2017

Conversation

devversion
Copy link
Member

  • Right now the MdDialog always instantiates the user-provided component with the injector from the MdDialog service.

    This is not valid, because developers can provide the viewContainerRef to create their dialog in the desired component structure and also expect the parent injector to be the same as in the viewContainerRef.

References #2374 (comment)

@devversion
fix(dialog): use injector from viewContainerRef if provided
3a78433 
* Right now the `MdDialog` always instantiates the user-provided component with the injector from the `MdDialog` service.

   This is not valid, because developers can provide the `viewContainerRef` to create their dialog in the desired component structure and also expect the parent injector to be the same as in the `viewContainerRef`.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 14, 2017
jelbourn
jelbourn approved these changes Jan 17, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 17, 2017
@mmalerba mmalerba merged commit be0da09 into angular:master Jan 19, 2017
kara pushed a commit to kara/material2 that referenced this pull request Jan 20, 2017
@devversion @kara
fix(dialog): use injector from viewContainerRef if provided (angular#…
32bf4b8 
…2655)

* Right now the `MdDialog` always instantiates the user-provided component with the injector from the `MdDialog` service.

   This is not valid, because developers can provide the `viewContainerRef` to create their dialog in the desired component structure and also expect the parent injector to be the same as in the `viewContainerRef`.
@devversion devversion deleted the fix/dialog-view-container-injector branch November 11, 2017 10:19
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @jelbourn @googlebot @mmalerba