Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icon): add caching of md-icon aria-label #2649

Merged
merged 1 commit into from
Jan 31, 2017

Conversation

westonpace
Copy link
Contributor

The md-icon component now caches the aria-label value and
only actually modifies the DOM if the value is unchanged.
This prevents md-icon from modifying the DOM every iteration
of change detection.

Closed #2642

The md-icon component now caches the aria-label value and
only actually modifies the DOM if the value is unchanged.
This prevents md-icon from modifying the DOM every iteration
of change detection.

Closed angular#2642
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 14, 2017
@jelbourn
Copy link
Member

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 25, 2017
@kara kara merged commit 08e9d70 into angular:master Jan 31, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

md-icon + resize-observer-polyfill = Infinite loop
4 participants