Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/dialog): Use align as @Input() in MatDialogActions #24333

Closed
wants to merge 1 commit into from

Conversation

devversion
Copy link
Member

Copy of #24328. Just to run CI since it didn't run on the author's PRs for quite some time now..

@devversion devversion added the blocked This issue is blocked by some external factor, such as a prerequisite PR label Feb 1, 2022
@PooSham
Copy link
Contributor

PooSham commented Feb 1, 2022

So the test names must match 1-to-1 between mdc and non-mdc? Can I push a fix directly to your branch, or should I push to my own branch so you can merge?

@PooSham
Copy link
Contributor

PooSham commented Feb 1, 2022

Or if you want to do it yourself, you can change:

  • line 1674 in src/material-experimental/mdc-dialog/dialog.spec.ts
  • line 1737 in src/material/dialog/dialog.spec.ts

to the following line:

it('should add correct css class according to given [align] input in [mat-dialog-actions]', () => {

@devversion
Copy link
Member Author

@PooSham you can just push to your PR and I will sync for another CI run.

@PooSham
Copy link
Contributor

PooSham commented Feb 1, 2022

@PooSham you can just push to your PR and I will sync for another CI run.

Should be alright now @devversion

@PooSham
Copy link
Contributor

PooSham commented Feb 1, 2022

I think I have fixed the errors now, you can give it another go. @devversion

@PooSham
Copy link
Contributor

PooSham commented Feb 1, 2022

Woohoo, it went through! What happens now?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked This issue is blocked by some external factor, such as a prerequisite PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants