Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autosize): export md-autosize directive #2432

Merged
merged 3 commits into from
Jan 4, 2017

Conversation

devversion
Copy link
Member

Note: Not sure whether mdTextareaAutosize is more appropriated here. Also notice that the method is already tested by the first test here

Closes #2419

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 27, 2016
@jelbourn
Copy link
Member

You're right, it should be mdTextareaAutosize (and the selector should be that too...).

@devversion
Copy link
Member Author

@jelbourn Updated the directive. Now the directive feels pretty long.

@@ -260,11 +260,11 @@
<md-card class="demo-card demo-basic">
<md-toolbar color="primary">Textarea Autosize</md-toolbar>
<md-card-content>
<textarea md-autosize class="demo-textarea"></textarea>
<textarea md-textarea-autosize class="demo-textarea"></textarea>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be mdTextareaAutosize (camelCase)

We should also make the old selector work at the same time as the new one for one release.
(so both md-autosize and mdTextAreaAutosize)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated it. Didn't add it for matTextareaAutosize because according to PR #2244 it's not needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a mat version too, but I've been lax on watching for that and will need to do another pass (probably at the same time I remove the deprecated selectors / properties).

@jelbourn
Copy link
Member

jelbourn commented Jan 3, 2017

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 3, 2017
@kara kara added pr: needs rebase and removed action: merge The PR is ready for merge by the caretaker labels Jan 4, 2017
@kara
Copy link
Contributor

kara commented Jan 4, 2017

@devversion Can you rebase?

@devversion
Copy link
Member Author

@kara Done.

@kara kara added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Jan 4, 2017
@kara kara merged commit f2d73da into angular:master Jan 4, 2017
@devversion devversion deleted the fix/textarea-autosize-export branch January 4, 2017 19:54
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

textarea not manually resizable via resizeToFitContent method
4 participants