-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(autosize): export md-autosize directive #2432
Conversation
You're right, it should be |
24cdad7
to
9ffcc71
Compare
@jelbourn Updated the directive. Now the directive feels pretty long. |
@@ -260,11 +260,11 @@ | |||
<md-card class="demo-card demo-basic"> | |||
<md-toolbar color="primary">Textarea Autosize</md-toolbar> | |||
<md-card-content> | |||
<textarea md-autosize class="demo-textarea"></textarea> | |||
<textarea md-textarea-autosize class="demo-textarea"></textarea> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be mdTextareaAutosize
(camelCase)
We should also make the old selector work at the same time as the new one for one release.
(so both md-autosize
and mdTextAreaAutosize
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated it. Didn't add it for matTextareaAutosize
because according to PR #2244 it's not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a mat
version too, but I've been lax on watching for that and will need to do another pass (probably at the same time I remove the deprecated selectors / properties).
LGTM |
@devversion Can you rebase? |
6b068b6
to
4cf3903
Compare
@kara Done. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Note: Not sure whether
mdTextareaAutosize
is more appropriated here. Also notice that the method is already tested by the first test hereCloses #2419