Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/menu): not interrupting keyboard events to other overlays #23310

Merged
merged 1 commit into from
Jan 15, 2022

Commits on Aug 4, 2021

  1. fix(material/menu): not interrupting keyboard events to other overlays

    This is a resubmit of angular#22856 which had some issues in g3.
    
    For historical reasons, `mat-menu` doesn't use the same keyboard event dispatcher as the other overlays. To work around it, previously we added a dummy subscription so that the menu would still show up in the overlay keyboard stack.
    
    This works for most events, but it breaks down for the escape key, because closing the menu removes it from the stack immediately, allowing the event to bubble up to the document and be dispatched to the next overlay in the stack.
    
    These changes resolve the issue by adding a stopPropagation call.
    
    Fixes angular#22694.
    crisbeto committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    71c6a6b View commit details
    Browse the repository at this point in the history