-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(material/schematics): add option not to include animations module in ng-add #22559
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
"x-prompt": "Set up browser animations for Angular Material?" | ||
"type": "string", | ||
"default": "enabled", | ||
"description": "Whether Angular browser animations should be included.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we elaborate here on which components strictly require an animations module to function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could, but then the option will be somewhat long and the list is bound to go out of date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the option is really useful without communicating that somehow, though. I wouldn't expect someone to go looking through the source to figure out where it's necessary, and letting someone omit animations just to then get an error when they try to use a component isn't a great experience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like that would be too much text to fit in a multi-select list in the command line. We could generate a list of components using animations from the source code and publish it as a URL on material.angular.io that we then link to from the schematic. It might take a while to do it though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like that would probably be useful. I've been meaning to write an "About" page for material.angular.io for a while and a good section there would be "Animations supports"
…e in ng-add Adds a third option to the `ng-add` schematic that allows users to opt out of including any of the animations modules.
c3bca6c
to
52ceaba
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds a third option to the
ng-add
schematic that allows users to opt out of including any of the animations modules.