Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/progress-spinner): resolve accessibility issue in ChromeVox #22219

Merged
merged 1 commit into from
Mar 19, 2021
Merged

fix(material/progress-spinner): resolve accessibility issue in ChromeVox #22219

merged 1 commit into from
Mar 19, 2021

Conversation

crisbeto
Copy link
Member

Along the same lines as #22166. Marks all the root nodes in the progress spinner as aria-hidden in order to work around an issue in ChromeVox.

@crisbeto
fix(material/progress-spinner): resolve accessibility issue in ChromeVox
32779d2 
Along the same lines as angular#22166. Marks all the root nodes in the progress spinner as
`aria-hidden` in order to work around an issue in ChromeVox.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Mar 13, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 13, 2021
jelbourn
jelbourn approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Mar 15, 2021
@andrewseguin andrewseguin merged commit 2da7135 into angular:master Mar 19, 2021
andrewseguin pushed a commit that referenced this pull request Mar 19, 2021
@crisbeto @andrewseguin
fix(material/progress-spinner): resolve accessibility issue in Chrome…
0e0b84a 
…Vox (#22219)

Along the same lines as #22166. Marks all the root nodes in the progress spinner as
`aria-hidden` in order to work around an issue in ChromeVox.

(cherry picked from commit 2da7135)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @jelbourn @andrewseguin