Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: run commit message check after other lint checks #22208

Merged
merged 1 commit into from
Mar 15, 2021
Merged

build: run commit message check after other lint checks #22208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,13 @@ jobs:
yarn check-entry-point-setup $(bazel info bazel-bin)/entry_points_manifest.json

- run: yarn ng-dev format changed --check << pipeline.git.base_revision >>
- run: yarn ownerslint
- run: yarn check-mdc-tests
- run: yarn stylelint
- run: yarn tslint
- run: yarn -s ts-circular-deps:check
- run: yarn check-mdc-exports
# Should be last so that it doesn't prevent the other lint checks from running.
- run:
name: Check Commit Message (PR Only)
# Only run the commit message checks on pull requests since we can't do
Expand All @@ -361,12 +368,6 @@ jobs:
if [ -n "$CIRCLE_PR_NUMBER" ]; then
yarn ng-dev commit-message validate-range --range $CI_COMMIT_RANGE
fi
- run: yarn ownerslint
- run: yarn check-mdc-tests
- run: yarn stylelint
- run: yarn tslint
- run: yarn -s ts-circular-deps:check
- run: yarn check-mdc-exports

- *slack_notify_on_failure
- *save_cache
Expand Down