-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(toolbar): add elevation styling #2212
Conversation
I think this probably needs a |
I don't think it would be necessary to add the elevation to the To be more flexible the developers should just apply the given Not sure we discussed this already when implementing the toolbar @jelbourn ? |
Agreed with @devversion, I would rather compose the re-usable elevation classes (e.g., |
Oh good, I didn't know those elevation classes existed. The main motivation to me is that the toolbar is barely visible without elevation, when it is plain without primary or accent theme. Dark theme is ok, but light theme it is hard to recognise it from the background. Maybe an example of using that class should be added to the toolbar readme? |
@jelbourn How do you use those elevation classes ? adding the classes doesn't add any shadow
|
@cedvdb - try "mat-elevation-z4" |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Elevation styling appears to have been implemented in most components, but toolbar was missed. This adds it for toolbar.