Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toolbar): add elevation styling #2212

Closed
wants to merge 1 commit into from

Conversation

code-tree
Copy link
Contributor

Elevation styling appears to have been implemented in most components, but toolbar was missed. This adds it for toolbar.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 14, 2016
@code-tree
Copy link
Contributor Author

I think this probably needs a z-index, but not sure what rules this project applies to setting that number.

@code-tree
Copy link
Contributor Author

Also, I think tabs' z-index will need to be raised so that the toolbar's shadow doesn't appear when placed above tabs.

image

@devversion
Copy link
Member

devversion commented Dec 14, 2016

I don't think it would be necessary to add the elevation to the md-toolbar by default.

To be more flexible the developers should just apply the given md-elevation-z4 class on the toolbar.

Not sure we discussed this already when implementing the toolbar @jelbourn ?

@jelbourn
Copy link
Member

Agreed with @devversion, I would rather compose the re-usable elevation classes (e.g., .md-elevation-z4) and toolbar rather than baking it in.

@jelbourn jelbourn closed this Dec 14, 2016
@code-tree
Copy link
Contributor Author

Oh good, I didn't know those elevation classes existed.

The main motivation to me is that the toolbar is barely visible without elevation, when it is plain without primary or accent theme. Dark theme is ok, but light theme it is hard to recognise it from the background.

Maybe an example of using that class should be added to the toolbar readme?

@Splaktar Splaktar mentioned this pull request Jan 25, 2017
@cedvdb
Copy link

cedvdb commented Aug 25, 2017

@jelbourn How do you use those elevation classes ? adding the classes doesn't add any shadow

<md-toolbar color="primary" class="md-elevation-z4">
  <close-icon-app (click)="menuOpened =  !menuOpened" [open]="menuOpened">
  </close-icon-app>
</md-toolbar>

@ghd8
Copy link

ghd8 commented Aug 25, 2017

@cedvdb - try "mat-elevation-z4"

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants