Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-form-field): always check hideRequiredMarker #22068

Merged
merged 3 commits into from
Mar 2, 2021
Merged

fix(material-experimental/mdc-form-field): always check hideRequiredMarker #22068

merged 3 commits into from
Mar 2, 2021

Conversation

andrewseguin
Copy link
Contributor

Doesn't appear to be any reason why this was an else if - the legacy form field does not do this. Reported internally by Googler

@andrewseguin andrewseguin added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Mar 1, 2021
@andrewseguin andrewseguin requested a review from devversion as a code owner March 1, 2021 18:23
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 1, 2021
wagnermaciel
wagnermaciel approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should we add a test to ensure we can simultaneously set appearance and hideRequiredMarker?

mmalerba
mmalerba approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin
Copy link
Contributor Author

Good suggestion on adding a. test - I added a check in there to prevent a regression

@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Mar 2, 2021
@wagnermaciel wagnermaciel merged commit d8935d1 into angular:master Mar 2, 2021
wagnermaciel pushed a commit that referenced this pull request Mar 2, 2021
@andrewseguin @wagnermaciel
fix(material-experimental/mdc-form-field): always check hideRequiredM…
020edd5 
…arker (#22068)

* fix(material-experimental/mdc-form-field): always check hideRequiredMarker

* fix(material-experimental/mdc-form-field): add test

* fix(material-experimental/mdc-form-field): add test to legacy

(cherry picked from commit d8935d1)
This was referenced Mar 6, 2021
Closed
Closed
Merged
Merged
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

@mmalerba mmalerba mmalerba approved these changes

@annieyw annieyw Awaiting requested review from annieyw

@devversion devversion Awaiting requested review from devversion

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewseguin @mmalerba @wagnermaciel