Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material-experimental/mdc-snack-bar): use mdc-button instead of l… #22030

Closed
wants to merge 1 commit into from

Conversation

annieyw
Copy link
Contributor

@annieyw annieyw commented Feb 26, 2021

…egacy button
Fixes #22024

@annieyw annieyw added P2 The issue is important to a large percentage of users, with a workaround G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release labels Feb 26, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 26, 2021

.mat-ripple-element {
background-color: currentColor;
opacity: 0.01;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied this over from the original button theme. Is there a variable for the ripple opacity I can use?

@annieyw annieyw requested a review from jelbourn February 26, 2021 00:45
@crisbeto
Copy link
Member

There's a PR that does this already #21442.

@annieyw annieyw closed this Feb 26, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(mdc-snack-bar): Still uses legacy mat-button
2 participants