feat(cdk/stepper): allow for orientation to be changed #21940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we have a limitation on the Material stepper that doesn't allow its orientation to be changed dynamically, because we have two different components for it. The CDK stepper doesn't have this limitation and people may end up extending it to implement their own steppers which support changing orientations. These changes add some logic to ensure that changing the orientation works as expected and to ensure that the orientation of the Material stepper doesn't change. Fixes angular#21874.
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
This was referenced Mar 11, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have a limitation on the Material stepper that doesn't allow its orientation to be changed dynamically, because we have two different components for it.
The CDK stepper doesn't have this limitation and people may end up extending it to implement their own steppers which support changing orientations.
These changes add some logic to ensure that changing the orientation works as expected and to ensure that the orientation of the Material stepper doesn't change.
Fixes #21874.