-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tabs): observing tab header label changes to recalculate width #2186
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
import {Component} from '@angular/core'; | ||
import {async, TestBed} from '@angular/core/testing'; | ||
import {ObserveContentModule} from './observe-content'; | ||
|
||
/** | ||
* TODO(elad): `ProxyZone` doesn't seem to capture the events raised by | ||
* `MutationObserver` and needs to be investigated | ||
*/ | ||
|
||
describe('Observe content', () => { | ||
beforeEach(async(() => { | ||
TestBed.configureTestingModule({ | ||
imports: [ObserveContentModule], | ||
declarations: [ComponentWithTextContent, ComponentWithChildTextContent], | ||
}); | ||
|
||
TestBed.compileComponents(); | ||
})); | ||
|
||
describe('text content change', () => { | ||
it('should call the registered for changes function', done => { | ||
let fixture = TestBed.createComponent(ComponentWithTextContent); | ||
fixture.detectChanges(); | ||
|
||
// If the hint label is empty, expect no label. | ||
const spy = spyOn(fixture.componentInstance, 'doSomething').and.callFake(() => { | ||
expect(spy.calls.any()).toBe(true); | ||
done(); | ||
}); | ||
|
||
expect(spy.calls.any()).toBe(false); | ||
|
||
fixture.componentInstance.text = 'text'; | ||
fixture.detectChanges(); | ||
}); | ||
}); | ||
|
||
describe('child text content change', () => { | ||
it('should call the registered for changes function', done => { | ||
let fixture = TestBed.createComponent(ComponentWithChildTextContent); | ||
fixture.detectChanges(); | ||
|
||
// If the hint label is empty, expect no label. | ||
const spy = spyOn(fixture.componentInstance, 'doSomething').and.callFake(() => { | ||
expect(spy.calls.any()).toBe(true); | ||
done(); | ||
}); | ||
|
||
expect(spy.calls.any()).toBe(false); | ||
|
||
fixture.componentInstance.text = 'text'; | ||
fixture.detectChanges(); | ||
}); | ||
}); | ||
}); | ||
|
||
|
||
@Component({ template: `<div (cdkObserveContent)="doSomething()">{{text}}</div>` }) | ||
class ComponentWithTextContent { | ||
text = ''; | ||
doSomething() {} | ||
} | ||
|
||
@Component({ template: `<div (cdkObserveContent)="doSomething()"><div>{{text}}<div></div>` }) | ||
class ComponentWithChildTextContent { | ||
text = ''; | ||
doSomething() {} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
import { | ||
Directive, | ||
ElementRef, | ||
NgModule, | ||
ModuleWithProviders, | ||
Output, | ||
EventEmitter, | ||
OnDestroy, | ||
AfterContentInit | ||
} from '@angular/core'; | ||
|
||
@Directive({ | ||
selector: '[cdkObserveContent]' | ||
}) | ||
export class ObserveContent implements AfterContentInit, OnDestroy { | ||
private _observer: MutationObserver; | ||
|
||
@Output('cdkObserveContent') event = new EventEmitter<void>(); | ||
|
||
constructor(private _elementRef: ElementRef) {} | ||
|
||
ngAfterContentInit() { | ||
this._observer = new MutationObserver(mutations => mutations.forEach(() => this.event.emit())); | ||
|
||
this._observer.observe(this._elementRef.nativeElement, { | ||
characterData: true, | ||
childList: true, | ||
subtree: true | ||
}); | ||
} | ||
|
||
ngOnDestroy() { | ||
if (this._observer) { | ||
this._observer.disconnect(); | ||
} | ||
} | ||
} | ||
|
||
@NgModule({ | ||
exports: [ObserveContent], | ||
declarations: [ObserveContent] | ||
}) | ||
export class ObserveContentModule { | ||
static forRoot(): ModuleWithProviders { | ||
return { | ||
ngModule: ObserveContentModule, | ||
providers: [] | ||
}; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not have below
And then in the test
(similar for other test)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tried this locally and I saw that the async stuff doesn't really work. Seems like zones doesn't play well with
MutationObserver
...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, Zones is supposed to understand
MutationObserver
, I'll have to check with Misko on this tomorrow.