Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(material-experimental/mdc-snack-bar): de-duplicate test harness logic #21496

Merged
merged 1 commit into from
Jan 9, 2021
Merged

refactor(material-experimental/mdc-snack-bar): de-duplicate test harness logic #21496

merged 1 commit into from
Jan 9, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 5, 2021

Changes the MDC-based MatSnackBarHarness to extend the non-MDC one since all the logic is the same, apart form a few selectors.

@crisbeto
refactor(material-experimental/mdc-snack-bar): de-duplicate test harn…
40efe3a 
…ess logic

Changes the MDC-based `MatSnackBarHarness` to extend the non-MDC one since
all the logic is the same, apart form a few selectors.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jan 5, 2021
@crisbeto crisbeto requested review from andrewseguin, jelbourn and a team as code owners January 5, 2021 14:15
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 5, 2021
josephperrott
josephperrott approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jan 5, 2021
andrewseguin
andrewseguin approved these changes Jan 8, 2021
View reviewed changes
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annieyw annieyw added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jan 9, 2021
@annieyw annieyw merged commit 7a8762a into angular:master Jan 9, 2021
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Jan 14, 2021
@crisbeto @wagnermaciel
refactor(material-experimental/mdc-snack-bar): de-duplicate test harn…
00c0062 
…ess logic (angular#21496)

Changes the MDC-based `MatSnackBarHarness` to extend the non-MDC one since
all the logic is the same, apart form a few selectors.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

@josephperrott josephperrott josephperrott approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @josephperrott @andrewseguin @mmalerba @annieyw