fix(material/tooltip): handle touch devices in test harness #21220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
crisbeto
force-pushed
the
tooltip-harness-touch-support
branch
2 times, most recently
from
f050fab to
d27949c
Compare
crisbeto
added
P3
`MatTooltip` binds either a mouse or a touch event, depending on whether it's on a touch device or not. In the harnesses we were limited to dispatching only mouse events which meant that tests couldn't be run against touch devices. Now that we can fake any sort of event, we're able to support touch devices too.
crisbeto
force-pushed
the
tooltip-harness-touch-support
branch
from
d27949c to
4ac69d5
Compare
annieyw
pushed a commit
that referenced
this pull request
Feb 9, 2021
`MatTooltip` binds either a mouse or a touch event, depending on whether it's on a touch device or not. In the harnesses we were limited to dispatching only mouse events which meant that tests couldn't be run against touch devices. Now that we can fake any sort of event, we're able to support touch devices too. (cherry picked from commit 24cbe1d)
annieyw
pushed a commit
that referenced
this pull request
Feb 9, 2021
`MatTooltip` binds either a mouse or a touch event, depending on whether it's on a touch device or not. In the harnesses we were limited to dispatching only mouse events which meant that tests couldn't be run against touch devices. Now that we can fake any sort of event, we're able to support touch devices too. (cherry picked from commit 24cbe1d)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MatTooltipbinds either a mouse or a touch event, depending on whether it's on a touch device or not. In the harnesses we were limited to dispatching only mouse events which meant that tests couldn't be run against touch devices.Now that we can fake any sort of event, we're able to support touch devices too.