feat(material/checkbox): Avoid nested divs in labels by changing to span instead. #20990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
jesscxu
force-pushed
the
update-span-to-div-nested-labels-checkbox
branch
from
5b9adfa
to
716ba7e
Compare
mmalerba
added
action: merge
mmalerba
pushed a commit
that referenced
this pull request
Nov 13, 2020
…pan instead. (#20990) Co-authored-by: Jessica Xu <[email protected]> (cherry picked from commit 94bd0d4)
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Dec 5, 2020
We made similar adjustments to other components that had `div` elements inside the control `label` (angular#20990, angular#20986), but we never fixed it for the slide toggle.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Change
<div>to<span>Why:
<div>elements should not be nested inside<label>elements because<label>only allows phrasing content