-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cdk/drag-drop): custom drag clone target #20537
feat(cdk/drag-drop): custom drag clone target #20537
Conversation
...k/drag-drop/cdk-drag-drop-custom-clone-target/cdk-drag-drop-custom-clone-target-example.html
Outdated
Show resolved
Hide resolved
@crisbeto hows this looking for you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but there are some places that still refer to the parent
value.
Ah, the MD file! I've fixed that now, the only references to parent left in the code are completely unrelated to the PR. Thank you for all your help on this btw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for the contribution!
@geometricpanda please rebase when possible |
@annieyw couldnt rebase as i cant get to my dev laptop until after UK lockdown, had to use the github merge tools which created a merge commit, hope that's ok? |
@geometricpanda One of your commit messages is not correctly formatted. If possible, please reword the invalid commit message |
it was having an issue with the github merge commit, now i've finally got my dev laptop back i've been able to rebase so fingers crossed it should be ok now? |
Any updates on this PR? It would be nice since I'm having styling issues |
There's been some major changes been merged into the way the drag container is being handled in the CDK which means this mechanism is no longer going to work I fear :-( |
@geometricpanda I don't think anything fundamentally changed in the module, but there were definitely some changes that could've caused merge conflicts. Do you intend on reopening this or should I pick up the feature request? |
I ended up re-implementing this myself in #21830. I also added support for |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
By default the drag directive clones the element it's applied to and appends to
the end of body. This change allows for a selector, HTML element, or an ElementRef
to be provided for the clone to be appended to instead.
Closes #20536 #13288