Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icon): remove svgSrc, only allow trusted urls #1933

Merged
merged 2 commits into from
Dec 21, 2016

Conversation

jelbourn
Copy link
Member

DO NOT MERGE UNTIL DEC 5th

R: @kara @andrewseguin
CC: @rjamet

This makes all SVG APIs on MdIconRegistry take a SafeResourceUrl instead of a string. This means that users must explicitly trust any URL used to load an SVG icon. This is necessary because we inline the SVGs into the document via innerHTML.

This also completely removes svgSrc from <md-icon> because it is not ergonomic to use with trusted URLs. We can explore adding it back in the future if we add support for a compile-time SVG cache.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 19, 2016
@jelbourn
Copy link
Member Author

@andrewseguin can you review?

Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Dec 20, 2016
@jelbourn jelbourn merged commit 4571561 into angular:master Dec 21, 2016
@jelbourn jelbourn deleted the icon-sec branch September 13, 2017 04:37
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants