fix(icon): remove svgSrc, only allow trusted urls #1933
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE UNTIL DEC 5th
R: @kara @andrewseguin
CC: @rjamet
This makes all SVG APIs on
MdIconRegistry
take aSafeResourceUrl
instead of astring
. This means that users must explicitly trust any URL used to load an SVG icon. This is necessary because we inline the SVGs into the document viainnerHTML
.This also completely removes
svgSrc
from<md-icon>
because it is not ergonomic to use with trusted URLs. We can explore adding it back in the future if we add support for a compile-time SVG cache.