build: disable sourcemap generation for all sass binaries #17291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
requested review from
andrewseguin,
crisbeto,
jelbourn,
mmalerba and
a team
as code owners
googlebot
added
the
cla: yes
We need to disable sourcemap generation for all sass binaries as otherwise the inline source map comment will be inlined into component `styles` in the release output. Technically this is not a big deal for AOT compilation where those source-map strings are omitted anyway, but for JIT it will contribute in payload size, and with the current state of Angular Package Format, these source-maps would point to non-existent files anyway. We should just not generate these sourcemaps/comments similarly to our Gulp release output.
devversion
force-pushed
the
build/disable-source-maps-for-all-sass-binaries
branch
from
84b034c to
a3b319c
Compare
devversion
added
pr: merge safe
target: major
josephperrott
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to disable sourcemap generation for all sass binaries
as otherwise the inline source map comment will be inlined into
component
stylesin the release output.Technically this is not a big deal for AOT compilation where those
source-map strings are omitted anyway, but for JIT it will contribute in
payload size, and with the current state of Angular Package Format, these
source-maps would point to non-existent files anyway.
We should just not generate these sourcemaps/comments similarly
to our Gulp build process. Fortunately moving stuff to
defaults.bzlmacro'smakes future re-enabling a one-liner. Plus it's easier to remind where to import
rules from (potentially also helpful if the sass rules become a Bazel NPM workspace)