Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update to angular v9.0.0-next.7 #17147

Merged
merged 2 commits into from
Sep 19, 2019
Merged

build: update to angular v9.0.0-next.7 #17147

merged 2 commits into from
Sep 19, 2019

Conversation

devversion
Copy link
Member

Updates to the latest Angular version so that we

  • can use ngcc to remove the workaround in the ivy snapshot test job.
  • use ts_library for secondary/tertiary entry-points instead of having to use ng_module as workaround.

@devversion
build: ensure postinstall patches are applied properly
9237f29 
Ensures the postinstall fails if some replacements could not
be made. This ensures that we don't update Angular and invalidate
some of the workarounds. This would result in broken release output then.
@devversion devversion requested review from jelbourn and a team as code owners September 19, 2019 18:02
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 19, 2019
@devversion devversion force-pushed the build/update-angular-next branch 2 times, most recently from 986c1c3 to 93aa150 Compare September 19, 2019 18:33
@devversion devversion force-pushed the build/update-angular-next branch 3 times, most recently from 43cd360 to e60cc9f Compare September 19, 2019 20:03
@devversion devversion force-pushed the build/update-angular-next branch from e60cc9f to c85ab3b Compare September 19, 2019 20:43
@devversion devversion added the target: major This PR is targeted for the next major release label Sep 19, 2019
jelbourn
jelbourn approved these changes Sep 19, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 19, 2019
@jelbourn jelbourn merged commit f537fba into angular:master Sep 19, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@crisbeto crisbeto Awaiting requested review from crisbeto

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devversion @jelbourn @googlebot