Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix docs not displaying inherited members properly #17145

Conversation

devversion
Copy link
Member

@devversion devversion commented Sep 19, 2019

Recently due to the MDC prototypes, we have multiple layers of inheritance. Apparently
our current docs tooling sometimes does not display inherited members which are coming
from implicitly inherited class-like documents.

For example: see how the MatTabLink docs broke when the MDC prototype
landed: angular/material2-docs-content@3389291

@devversion devversion added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: merge safe target: patch This PR is targeted for the next patch release labels Sep 19, 2019
@devversion devversion requested a review from a team as a code owner September 19, 2019 15:33
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 19, 2019
@devversion devversion changed the title build: fix docs not display inherited members properly build: fix docs not displaying inherited members properly Sep 19, 2019
Recently due to the MDC prototypes, we have multiple layers of inheritance. Apparently
our current docs tooling sometimes does not display inherited members which are coming
from implicitly inherited class-like documents.

For example: see how the `MatTabLink` docs broke when the MDC prototype
landed: angular@492fdcc40
@devversion devversion force-pushed the build/fix-docs-inherited-members-grandparent branch from 3bd9850 to 58af7b5 Compare September 19, 2019 15:34
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 19, 2019
@jelbourn jelbourn merged commit f00ae8d into angular:master Sep 19, 2019
jelbourn pushed a commit to jelbourn/components that referenced this pull request Sep 24, 2019
)

Recently due to the MDC prototypes, we have multiple layers of inheritance. Apparently
our current docs tooling sometimes does not display inherited members which are coming
from implicitly inherited class-like documents.

For example: see how the `MatTabLink` docs broke when the MDC prototype
landed: angular@492fdcc40

(cherry picked from commit f00ae8d)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants