-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prototype(tabs): create prototype tabs based on MDC web #16805
Conversation
a6aa3e5
to
176ea0d
Compare
cc @abhiomkar FYI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at the demo locally, seems like the label font color in dark mode is still black. Is that part of the tabs theme?
} | ||
} | ||
|
||
// MDC doesn't support disabled tabs so we need to improvise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should file this as a feature request (or bug) since aria-disabled
is a supported state for role="tab"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My guess is that it's not there, because it's not in the spec either: https://material.io/components/tabs/#states.
4c3c88f
to
503d3c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks like I rebased this while there were build errors in master. It should be rebased once #16928 gets in. |
@crisbeto when you get a chance, could you rebase this again? |
Rebased @jelbourn. |
Adds an implementation of the Angular Material tabs that is based on MDC web. The API is exactly the same, except for a couple of differences: 1. The ink bar has been switched to use MDC's `tab-indicator`. As such the styling and the animation are slightly different. 2. Previously `MatTabLink` used to be a `Directive`, however now it's a `Component`, because we need some extra markup around the content.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds an implementation of the Angular Material tabs that is based on MDC web. The API is exactly the same, except for a couple of differences:
tab-indicator
. As such the styling and the animation are slightly different.MatTabLink
used to be aDirective
, however now it's aComponent
, because we need some extra markup around the content.Note: this is not merge safe, because I had to move a few things around in the current tabs module.