Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/tooltip): clear pending timers on destroy #16756

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

crisbeto
Copy link
Member

Currently we fire off some timers when a tooltip is shown or hidden, however if it gets destroyed before the timer has elapsed, we still end up executing some logic (change detection in this case). These changes clear the timers so that we don't end up triggering errors by accident.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Aug 12, 2019
@crisbeto crisbeto requested a review from andrewseguin as a code owner August 12, 2019 14:35
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 12, 2019
@andrewseguin andrewseguin added lgtm action: merge The PR is ready for merge by the caretaker labels Jun 15, 2020
@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@crisbeto crisbeto changed the title fix(tooltip): clear pending timers on destroy fix(material/tooltip): clear pending timers on destroy Feb 9, 2021
@crisbeto crisbeto force-pushed the tooltip-clear-timeouts branch from 266922f to b92168e Compare February 9, 2021 18:22
Currently we fire off some timers when a tooltip is shown or hidden, however if it gets
destroyed before the timer has elapsed, we still end up executing some logic (change
detection in this case). These changes clear the timers so that we don't end up triggering
errors by accident.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants