-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(textarea): add md-textarea element #1562
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
e84365c
add textarea
42b7592
adress comments
f53e654
make autosize work along rows
17c2761
change innerHTML to value
ddda4ed
replace replace with parseFloat
41cfdd5
fix "supports a name attribute test"
6f2354c
remove unused import
ba71282
change rows in textarea demo to by dynamic
262785c
rebase + remove autosize
acac45e
remove autosize from demo-app
4784301
remove unused imports
95e6bab
address comments, add tests
6bf5613
prefix element type with underscore
43a6762
proper type of wrap
88a560b
remove public from element ref injection
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,7 @@ | |
|
||
<div class="md-input-infix"> | ||
<input #input | ||
*ngIf="_elementType === 'input'" | ||
class="md-input-element" | ||
[class.md-end]="align == 'end'" | ||
[attr.aria-label]="ariaLabel" | ||
|
@@ -34,6 +35,37 @@ | |
[(ngModel)]="value" | ||
(change)="_handleChange($event)"> | ||
|
||
<textarea | ||
#input | ||
*ngIf="_elementType === 'textarea'" | ||
class="md-input-element md-input-element-textarea" | ||
[class.md-end]="align == 'end'" | ||
[attr.aria-label]="ariaLabel" | ||
[attr.aria-labelledby]="ariaLabelledBy" | ||
[attr.aria-disabled]="ariaDisabled" | ||
[attr.aria-required]="ariaRequired" | ||
[attr.aria-invalid]="ariaInvalid" | ||
[attr.autocomplete]="autocomplete" | ||
[attr.autocapitalize]="autocapitalize" | ||
[attr.cols]="cols" | ||
[attr.rows]="rows" | ||
[attr.wrap]="wrap" | ||
[autofocus]="autofocus" | ||
[disabled]="disabled" | ||
[id]="inputId" | ||
[attr.maxlength]="maxlength" | ||
[attr.minlength]="minlength" | ||
[readonly]="readonly" | ||
[required]="required" | ||
[spellcheck]="spellcheck" | ||
[attr.tabindex]="tabindex" | ||
[attr.name]="name" | ||
(focus)="_handleFocus($event)" | ||
(blur)="_handleBlur($event)" | ||
[(ngModel)]="value" | ||
(change)="_handleChange($event)"></textarea> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can remove min, max, and autocorrect. They don't exist on We should add https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea |
||
|
||
|
||
<label class="md-input-placeholder" | ||
[attr.for]="inputId" | ||
[class.md-empty]="empty" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just FYI: we're probably going to do away with these internal elements and content-project an input from the user.