Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(material/tooltip): add class to tooltip element based on the current position #15217

Merged
merged 1 commit into from
Feb 10, 2021
Merged

feat(material/tooltip): add class to tooltip element based on the current position #15217

merged 1 commit into from
Feb 10, 2021
+194 −2

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 17, 2019 •
edited
Loading

Adds a class on the tooltip overlay element that indicates the current position of the tooltip. This allows for the it to be customized to add position-based arrows or box shadows.

Fixes #15216.

@crisbeto crisbeto added the target: minor This PR is targeted for the next minor release label Feb 17, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 17, 2019
@crisbeto crisbeto force-pushed the 15216/tooltip-position-class branch 2 times, most recently from 5556029 to 712fdf0 Compare February 17, 2019 17:20
@crisbeto crisbeto force-pushed the 15216/tooltip-position-class branch from 712fdf0 to 68ab64b Compare March 16, 2019 16:01
@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
@andrewseguin andrewseguin added the P4 A relatively minor issue that is not relevant to core functions label May 30, 2019
@crisbeto crisbeto force-pushed the 15216/tooltip-position-class branch from 68ab64b to 630925e Compare June 8, 2019 17:32
@crisbeto crisbeto force-pushed the 15216/tooltip-position-class branch from 630925e to ece32a6 Compare August 7, 2019 12:41
@crisbeto crisbeto force-pushed the 15216/tooltip-position-class branch from ece32a6 to c0baf8f Compare September 14, 2019 11:31
@crisbeto crisbeto force-pushed the 15216/tooltip-position-class branch from c0baf8f to 40ef501 Compare January 31, 2020 22:14
@crisbeto crisbeto force-pushed the 15216/tooltip-position-class branch from 40ef501 to dea4ada Compare February 10, 2020 20:41
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed P4 A relatively minor issue that is not relevant to core functions labels Jun 3, 2020
mmalerba
mmalerba approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added lgtm action: merge The PR is ready for merge by the caretaker labels Jun 3, 2020
@crisbeto crisbeto force-pushed the 15216/tooltip-position-class branch from dea4ada to 160f134 Compare July 16, 2020 21:15
@crisbeto crisbeto force-pushed the 15216/tooltip-position-class branch from 160f134 to ead811b Compare July 26, 2020 10:40
@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@crisbeto crisbeto force-pushed the 15216/tooltip-position-class branch from ead811b to c66f6ef Compare August 22, 2020 14:32
@crisbeto crisbeto changed the title feat(tooltip): add class to tooltip element based on the current position feat(material/tooltip): add class to tooltip element based on the current position Feb 9, 2021
@crisbeto
feat(material/tooltip): add class to tooltip element based on the cur…
325c4b2 
…rent position

Adds a class on the tooltip overlay element that indicates the current position of the
tooltip. This allows for the tooltip to be customized to add position-based arrows or
box shadows.

Fixes angular#15216.
@crisbeto crisbeto force-pushed the 15216/tooltip-position-class branch from c66f6ef to 325c4b2 Compare February 9, 2021 18:21
@mmalerba mmalerba merged commit 1a10027 into angular:master Feb 10, 2021
This was referenced Mar 11, 2021
Closed
Merged
Merged
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@mmalerba mmalerba

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose effective tooltip position as a class on the tooltip component
5 participants
@crisbeto @mmalerba @jelbourn @googlebot @andrewseguin