-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sort): display mat-sort-header arrow when sorting programmatically #13171
Conversation
@andrewseguin can you review? |
My apologies for the late review, we should have checked this out sooner. Thanks for making this pull request, everything looks great. The only nit I see with this implementation is that there is no animation when sort is activated programatically. It looks like the arrow just appears. This also comes up when you cycle through a header's sort state (active -> asc -> desc -> inactive -> active). The second active does not show an animation, but just appears without floating in. These are minor issues and I'd rather see this fix go in even if it means a small regression in animations. If you get some time, could you take a look into see if you can resolve this small issue? If not, let's go ahead and get this merged. Thanks again for the PR |
Can you please fix circle so that this PR can be merged? @andrewseguin @leduyminh48 |
@andrewseguin: I don't think I will have the time to look into the animations issue in the near future. |
25720a6
to
539ed14
Compare
@andrewseguin @leduyminh48 any idea when this PR will be merged? It's been outstanding for awhile. Thank you |
Fix mat-sort-header arrow not displaying after sorting programmatically (eg. `matSort.sort()`) Related to angular#10242, angular#12754
539ed14
to
410bd64
Compare
410bd64
to
0d02c5a
Compare
Why is it unexpected? It is just a regular module import. This error tells me nothing useful. @jelbourn, @andrewseguin I don't have time to debug this. This PR has been open for almost a whole year now. If you have any intention of fixing this bug, please take over from here. Otherwise, feel free to close this PR. |
This should be captured by #19492 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fix mat-sort-header arrow not displaying after sorting programmatically (eg.
matSort.sort()
)Related to #10242, #12754