feat(radio): Radio component. #125
Conversation
googlebot
added
cla: yes
| } | ||
|
|
||
| md-radio-group { | ||
| } |
|
Could you rebase? I have a feeling it will be green(er). |
|
Ready for another round. Will get started with tests soon. |
| // TODO(mtlin): Replace when ink ripple component is implemented. | ||
| // A placeholder ink ripple, shown when keyboard focused. | ||
| .md-ink-ripple { | ||
| background: #000; |
There was a problem hiding this comment.
Should this be one of the theme background colors?
There was a problem hiding this comment.
This one's below, in the theme section.
| fixture.detectChanges(); | ||
| expect(button.componentInstance.checked).toBe(false); | ||
|
|
||
| let event = new Event('change'); |
There was a problem hiding this comment.
Doesn't new Event not work in IE11?
|
Ready for another look. |
|
LGTM |
jelbourn
added
pr: lgtm
and removed
in progress
| forwardRef | ||
| } from 'angular2/core'; | ||
|
|
||
| import {EventEmitter} from 'angular2/src/facade/async'; |
There was a problem hiding this comment.
I think you should be able to get this from 'angular2/core' as well, if you want to simplify imports
|
Updated with changes from @kara 's comments. |
|
Those are just flakes on Edge |
… new version of cli (angular#125)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
@jelbourn @hansl @kara
Looking to get an initial pass first and then if it's looking close I'll update with tests.
Thanks!