Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chips): support focusing first/last item using home/end #11892

Merged
merged 1 commit into from
Aug 23, 2018
Merged

fix(chips): support focusing first/last item using home/end #11892

merged 1 commit into from
Aug 23, 2018

Conversation

crisbeto
Copy link
Member

Based on the accessibility guidelines, grid cells should support moving focus to the first/last items via the Home and End keys.

@crisbeto crisbeto added the Accessibility This issue is related to accessibility (a11y) label Jun 22, 2018
@crisbeto crisbeto requested a review from tinayuangao as a code owner June 22, 2018 17:04
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 22, 2018
@josephperrott josephperrott added the target: patch This PR is targeted for the next patch release label Jun 26, 2018
jelbourn
jelbourn approved these changes Jul 17, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 17, 2018
@ngbot
Copy link

ngbot bot commented Aug 23, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@ngbot ngbot bot unassigned tinayuangao Aug 23, 2018
@crisbeto
fix(chips): support focusing first/last item using home/end
d96ad0e 
Based on the accessibility guidelines, grid cells should support moving focus to the first/last items via the Home and End keys.
@jelbourn jelbourn merged commit 3723191 into angular:master Aug 23, 2018
jelbourn pushed a commit that referenced this pull request Aug 29, 2018
@crisbeto @jelbourn
fix(chips): support focusing first/last item using home/end (#11892)
b735e48 
Based on the accessibility guidelines, grid cells should support moving focus to the first/last items via the Home and End keys.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@tinayuangao tinayuangao Awaiting requested review from tinayuangao

Assignees

@jelbourn jelbourn

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @jelbourn @googlebot @josephperrott @tinayuangao