Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schematics): add app prefix to components #11738

Merged
merged 1 commit into from
Jun 13, 2018

Conversation

amcdnl
Copy link
Contributor

@amcdnl amcdnl commented Jun 10, 2018

Adds the prefix to the generated components. Addresses #11525

@amcdnl amcdnl self-assigned this Jun 10, 2018
@amcdnl amcdnl requested a review from jelbourn June 10, 2018 14:54
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 10, 2018
@@ -49,6 +49,9 @@ export interface Workspace {
export interface Project {
name: string;

/** Application prefix. */
prefix: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless this is part of the Angular CLI's actual project schema, we can't add this extra property here without also making it non-enumerable because we reserialize this object and write it to disk when we're e.g. adding a theme.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is in the actual schema. I pulled this code from official component schematic - https://github.com/angular/angular-cli/blob/master/packages/schematics/angular/component/index.ts#L116-L125

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 12, 2018
@jelbourn jelbourn merged commit 84634cc into angular:master Jun 13, 2018
@amcdnl amcdnl deleted the schematic-prefix branch June 15, 2018 15:34
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants