-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(schematics): add app prefix to components #11738
Conversation
@@ -49,6 +49,9 @@ export interface Workspace { | |||
export interface Project { | |||
name: string; | |||
|
|||
/** Application prefix. */ | |||
prefix: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless this is part of the Angular CLI's actual project schema, we can't add this extra property here without also making it non-enumerable because we reserialize this object and write it to disk when we're e.g. adding a theme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is in the actual schema. I pulled this code from official component schematic - https://github.com/angular/angular-cli/blob/master/packages/schematics/angular/component/index.ts#L116-L125
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds the prefix to the generated components. Addresses #11525