Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix(tabs): Add role to mat-tab-nav-bar and mat-tab-link" #11657

Merged
merged 1 commit into from
Jun 4, 2018
Merged

Revert "fix(tabs): Add role to mat-tab-nav-bar and mat-tab-link" #11657

merged 1 commit into from
Jun 4, 2018

Conversation

tinayuangao
Copy link
Contributor

Material nav-tabs intentionally behaves as a nav + anchor

@tinayuangao
Revert "fix(tabs): Add role to mat-tab-nav-bar and mat-tab-link"
d8f115c 
 Material nav-tabs intentionally behaves as a nav + anchor
@tinayuangao tinayuangao requested a review from andrewseguin as a code owner June 4, 2018 18:53
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 4, 2018
@tinayuangao tinayuangao requested a review from jelbourn June 4, 2018 18:53
jelbourn
jelbourn approved these changes Jun 4, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 4, 2018
@jelbourn jelbourn mentioned this pull request Jun 4, 2018
Merged
@andrewseguin andrewseguin merged commit b962eee into angular:master Jun 4, 2018
andrewseguin pushed a commit that referenced this pull request Jun 4, 2018
@tinayuangao @andrewseguin
Revert "fix(tabs): Add role to mat-tab-nav-bar and mat-tab-link" (#11657
1fc14a0 
)

Material nav-tabs intentionally behaves as a nav + anchor
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tinayuangao @jelbourn @googlebot @andrewseguin