Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mat-input): add a check for the current platform #11604

Merged
merged 1 commit into from
Aug 24, 2018
Merged

fix(mat-input): add a check for the current platform #11604

merged 1 commit into from
Aug 24, 2018

Conversation

arturovt
Copy link
Contributor

Allow AutofillMonitor.monitor and AutofillMonitor.stopMonitoring methods to be called only on the client side.

Fixes #11603

@arturovt arturovt requested a review from mmalerba as a code owner May 31, 2018 16:17
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label May 31, 2018
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels May 31, 2018
@crisbeto
Copy link
Member

This might be within the same scope as #11586 @josephperrott.

@josephperrott
Copy link
Member

josephperrott commented Jul 2, 2018

From reading through this change, I don't know that this is necessarily the right action to take.

The first step in the monitor method is to check the platform that is being used. So while, they will be able to be called on the server side, they amount to a noop in that situation anyway.

@mmalerba mmalerba requested a review from josephperrott July 16, 2018 19:49
@mmalerba mmalerba removed their request for review July 16, 2018 19:49
@josephperrott josephperrott added target: patch This PR is targeted for the next patch release pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 31, 2018
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: nevermind, I just read through the entire conversation.

I don't think that these changes are necessary, because the autofill monitor does it internally already. See: https://github.com/angular/material2/blob/master/src/cdk/text-field/autofill.ts#L60

@ngbot
Copy link

ngbot bot commented Aug 23, 2018

Hi @arturovt! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@jelbourn
Copy link
Member

@arturovt could you rebase this PR?

@jelbourn jelbourn merged commit 625f792 into angular:master Aug 24, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
@arturovt arturovt deleted the fix_input_monitor branch November 22, 2019 20:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mat-input] SSR crashes because of undefined functions
5 participants