-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mat-input): add a check for the current platform #11604
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
CLAs look good, thanks! |
This might be within the same scope as #11586 @josephperrott. |
From reading through this change, I don't know that this is necessarily the right action to take. The first step in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EDIT: nevermind, I just read through the entire conversation.
I don't think that these changes are necessary, because the autofill monitor does it internally already. See: https://github.com/angular/material2/blob/master/src/cdk/text-field/autofill.ts#L60
Hi @arturovt! This PR has merge conflicts due to recent upstream merges. |
@arturovt could you rebase this PR? |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Allow
AutofillMonitor.monitor
andAutofillMonitor.stopMonitoring
methods to be called only on the client side.Fixes #11603