Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

button will append one <div lass="md-ripple-foreground md-ripple-fade-in" style="..."> when clicked #997

Closed
dennis-xlc opened this issue Aug 11, 2016 · 4 comments

Comments

@dennis-xlc
Copy link

dennis-xlc commented Aug 11, 2016

Bug, feature request, or proposal:

Bug

What is the expected behavior?

<div lass="md-ripple-foreground md-ripple-fade-in" style="..."> will disappeared after clicked

What is the current behavior?

<div lass="md-ripple-foreground md-ripple-fade-in" style="..."> remain at DOM after click

What are the steps to reproduce?

  1. add one button at the template
    <button md-icon-button> <md-icon>menu</md-icon> </button>
  2. click on the button repeatedly until exceed current height of DOM
  3. check the source of DOM, will find many <div lass="md-ripple-foreground md-ripple-fade-in" style="...">

Providing a Plunker (or similar) is the best way to get the team to see your issue.
Plunker template: http://plnkr.co/edit/o077B6uEiiIgkC0S06dd
cannot reproduced at Plunker

What is the use-case or motivation for changing an existing behavior?

This behavior will break the normal DOM

Which versions of Angular, Material, OS, browsers are affected?

Angular Version: 2.0.0-rc.5
Material Version: @angular2-material/[email protected]
OS: Windows 7
Browser Version: Google Chrome 52.0.2743.116 m

Is there anything else we should know?

@colinfang
Copy link

Dupe of #972

@ultrapromedia
Copy link

Confirmed

@jelbourn
Copy link
Member

Closing as dupe.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
alexeagle pushed a commit to alexeagle/material2 that referenced this issue Nov 6, 2024
…les (angular#1009)

- remove tslint and codelyzer from examples
- update jasmine dependencies
- remove unused material-module.ts from test assets
- add jasmine-core to package.json in stack-blitz-tests/
- disable `noImplicitAny` in stack-blitz-tests' tsconfig.spec.json since
  `jasmine-core/lib/jasmine-core/jasmine.js` imported in `test/jasemine-setup.ts`
   is not compatible

Fixes angular#997
alexeagle pushed a commit to alexeagle/material2 that referenced this issue Dec 12, 2024
…les (angular#1009)

- remove tslint and codelyzer from examples
- update jasmine dependencies
- remove unused material-module.ts from test assets
- add jasmine-core to package.json in stack-blitz-tests/
- disable `noImplicitAny` in stack-blitz-tests' tsconfig.spec.json since
  `jasmine-core/lib/jasmine-core/jasmine.js` imported in `test/jasemine-setup.ts`
   is not compatible

Fixes angular#997
alexeagle pushed a commit to alexeagle/material2 that referenced this issue Dec 16, 2024
…les (angular#1009)

- remove tslint and codelyzer from examples
- update jasmine dependencies
- remove unused material-module.ts from test assets
- add jasmine-core to package.json in stack-blitz-tests/
- disable `noImplicitAny` in stack-blitz-tests' tsconfig.spec.json since
  `jasmine-core/lib/jasmine-core/jasmine.js` imported in `test/jasemine-setup.ts`
   is not compatible

Fixes angular#997
alexeagle pushed a commit to alexeagle/material2 that referenced this issue Dec 18, 2024
…les (angular#1009)

- remove tslint and codelyzer from examples
- update jasmine dependencies
- remove unused material-module.ts from test assets
- add jasmine-core to package.json in stack-blitz-tests/
- disable `noImplicitAny` in stack-blitz-tests' tsconfig.spec.json since
  `jasmine-core/lib/jasmine-core/jasmine.js` imported in `test/jasemine-setup.ts`
   is not compatible

Fixes angular#997
josephperrott pushed a commit that referenced this issue Dec 18, 2024
…les (#1009)

- remove tslint and codelyzer from examples
- update jasmine dependencies
- remove unused material-module.ts from test assets
- add jasmine-core to package.json in stack-blitz-tests/
- disable `noImplicitAny` in stack-blitz-tests' tsconfig.spec.json since
  `jasmine-core/lib/jasmine-core/jasmine.js` imported in `test/jasemine-setup.ts`
   is not compatible

Fixes #997
alexeagle pushed a commit to alexeagle/material2 that referenced this issue Dec 18, 2024
…les (angular#1009)

- remove tslint and codelyzer from examples
- update jasmine dependencies
- remove unused material-module.ts from test assets
- add jasmine-core to package.json in stack-blitz-tests/
- disable `noImplicitAny` in stack-blitz-tests' tsconfig.spec.json since
  `jasmine-core/lib/jasmine-core/jasmine.js` imported in `test/jasemine-setup.ts`
   is not compatible

Fixes angular#997
kseamon pushed a commit to kseamon/material2 that referenced this issue Dec 18, 2024
…les (angular#1009)

- remove tslint and codelyzer from examples
- update jasmine dependencies
- remove unused material-module.ts from test assets
- add jasmine-core to package.json in stack-blitz-tests/
- disable `noImplicitAny` in stack-blitz-tests' tsconfig.spec.json since
  `jasmine-core/lib/jasmine-core/jasmine.js` imported in `test/jasemine-setup.ts`
   is not compatible

Fixes angular#997
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants