Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ripples behavior on touch-enabled devices doesn't match Android ripples behavior #7062

Closed
dgadelha opened this issue Sep 14, 2017 · 2 comments · Fixed by #7299 or #7927
Closed

Ripples behavior on touch-enabled devices doesn't match Android ripples behavior #7062

dgadelha opened this issue Sep 14, 2017 · 2 comments · Fixed by #7299 or #7927
Assignees

Comments

@dgadelha
Copy link

dgadelha commented Sep 14, 2017

Bug, feature request, or proposal:

Ripples behavior on touch-enabled devices doesn't match Android ripples behavior.

The ripple should happen during the touch, not after it.

What is the expected behavior?

2017-09-13_22-34-37

What is the current behavior?

2017-09-13_22-35-50

Please note that the ripple happened in the end, a bit of time after the button was clicked.

What are the steps to reproduce?

Go to https://material.angular.io/

What is the use-case or motivation for changing an existing behavior?

Follow Android design.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

The latest ones for everything.

Is there anything else we should know?

The issue is also present when you enable touch-mode on Firefox for Windows. Untested on Chrome for Windows. The issue affects Chrome for Android and Firefox for Android, all latest versions.

Materialize CSS framework seems to have fixed this issue.

devversion added a commit to devversion/material2 that referenced this issue Sep 25, 2017
* Ripples are now launched on touchstart for touch devices. Before they were just launched after the click happened.

Fixes angular#7062
andrewseguin pushed a commit that referenced this issue Sep 29, 2017
* fix(ripple): handle touch events

* Ripples are now launched on touchstart for touch devices. Before they were just launched after the click happened.

Fixes #7062

* Address feedback
@dgadelha
Copy link
Author

Thank you!

@devversion devversion reopened this Oct 20, 2017
devversion added a commit to devversion/material2 that referenced this issue Oct 20, 2017
* Now handles touch events properly.

Fixes angular#7062
devversion added a commit to devversion/material2 that referenced this issue Oct 21, 2017
* Now handles touch events properly.

Fixes angular#7062
jelbourn pushed a commit that referenced this issue Nov 18, 2017
* Now handles touch events properly.

Fixes #7062
devversion added a commit to devversion/material2 that referenced this issue Nov 19, 2017
* Now handles touch events properly.

Fixes angular#7062
tinayuangao pushed a commit that referenced this issue Nov 28, 2017
* Now handles touch events properly.

Fixes #7062
tinayuangao pushed a commit to tinayuangao/material2 that referenced this issue Nov 29, 2017
* Now handles touch events properly.

Fixes angular#7062
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants