Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio-button label doesn't wrap by default, unlike check-box label. Couldn't make it wrap with CSS either. #6671

Closed
srix55 opened this issue Aug 28, 2017 · 2 comments · Fixed by #6674
Assignees

Comments

@srix55
Copy link

srix55 commented Aug 28, 2017

Bug, feature request, or proposal:

Bug

What is the expected behavior?

The label should wrap for longer labels

What is the current behavior?

Doesn't wrap. Overflows container.

What are the steps to reproduce?

http://plnkr.co/edit/PS09vZVKMQxIMLd72mSS?p=preview

What is the use-case or motivation for changing an existing behavior?

Radio button labels overflow their card containers and are displayed with an ugly horizontal scrollbar when viewed on a mobile device

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

@angular/compiler: 4.3.1
@angular/material: 2.0.0-beta.8-374aaff

Is there anything else we should know?

I tried the solutions related to issue #2019 . Couldn't make it work.

@julianobrasil
Copy link
Contributor

julianobrasil commented Aug 28, 2017

You can make your style global and apply it to your radio:

<md-radio-button class="myClass"></md-radio-button>

Where myClass is defined globally:

.myClass > label {
    white-space: normal;
}

plunk: http://plnkr.co/edit/s105l0VXQDv9byVyHLAE?p=preview

@devversion devversion self-assigned this Aug 28, 2017
devversion added a commit to devversion/material2 that referenced this issue Aug 28, 2017
* Similar as for the radio component, the checkbox label content should not wrap if it exceeds the boundaries of the parent element. This ensures that we have consistent behavior across all selection controls.
* Fixes that the radio container (circle) shrinks if the label content is exceeding the boundaries and wrapping is enabled (developers may overwrite CSS to enable wrapping)

Closes angular#6671
jelbourn pushed a commit that referenced this issue Aug 30, 2017
* Similar as for the radio component, the checkbox label content should not wrap if it exceeds the boundaries of the parent element. This ensures that we have consistent behavior across all selection controls.
* Fixes that the radio container (circle) shrinks if the label content is exceeding the boundaries and wrapping is enabled (developers may overwrite CSS to enable wrapping)

Closes #6671
jelbourn pushed a commit that referenced this issue Sep 1, 2017
* Similar as for the radio component, the checkbox label content should not wrap if it exceeds the boundaries of the parent element. This ensures that we have consistent behavior across all selection controls.
* Fixes that the radio container (circle) shrinks if the label content is exceeding the boundaries and wrapping is enabled (developers may overwrite CSS to enable wrapping)

Closes #6671
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants