MdCheckbox fires a click event twice

[chrismcgregor]

I noticed that the (click) event is being called twice for MdCheckbox.

[sendilkumarn]

On disable - click function is executed.

[chrismcgregor]

Sendi,

I get two events for (click) when clicking on a checkbox and it is not disabled. I am now using (change) event, which only fires one event. I have something working now.

By the way, great stuff with Angular2-material.

Cheers!

Chris

Christopher McGregor
415.624.6261 // [email protected]

On Jun 8, 2016, at 3:07 AM, Sendil Kumar N [email protected] wrote:

On disable - click function is executed.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #651 (comment), or mute the thread https://github.com/notifications/unsubscribe/AH_7Vz8UDhgd6s8DuFyqVRLiXIfEqzL3ks5qJpRhgaJpZM4IwiIr.

[webmutation]

Should the checkbox keep the shadow?
The animation does not seem to complete after the click.

[Neozaru]

Apparently, when registering (click) event on the md-checkbox, the event is handled by the parent element but is also handled by the <input> element when not disabled.
On my side, what does work is parasitizing (click) events ($event.stopPropagation()) on the input itself, and handling it on the top-level element, stopping propagation if disabled.
Note that the (click) event triggered when pressing SPACE key is also blocked when stopping propagation from the <input>.
ngChange behavior remains the same.
Looking for a better solution.

[Neozaru]

@robertmesserle FYI I also worked on it last evening and ended up with an ugly solution. You can still take the unit tests from it (src/components/checkbox/checkbox.spec.ts) : https://github.com/angular/material2/compare/master...Neozaru:bugfixes/checkbox-click-event-once?expand=1

[robertmesserle]

Closed the wrong thing.

[jelbourn]

Fixed in #672

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}