Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[audit] use of coerceBooleanProperty #6370

Closed
willshowell opened this issue Aug 9, 2017 · 2 comments
Closed

[audit] use of coerceBooleanProperty #6370

willshowell opened this issue Aug 9, 2017 · 2 comments
Labels
P4 A relatively minor issue that is not relevant to core functions

Comments

@willshowell
Copy link
Contributor

willshowell commented Aug 9, 2017

Bug, feature request, or proposal:

Suggesting library-wide audit

Expected

Consistent use

Currently

At least two boolean inputs (1 2) do not use it

Motivation

#6344 (comment), #6097 (comment)

Is there anything else we should know?

IMO it should be removed entirely as it encourages misuse of bindings that won't translate outside this library. For reference, the original commit used it in the form of @BooleanFieldValue().

@jelbourn
Copy link
Member

We should use it consistently everywhere. It's necessary at the very least to make things like disabled, readonly, required, and checked work correctly.

My long-term goal is to convince core to do angular/angular#8968

@jelbourn jelbourn added the P4 A relatively minor issue that is not relevant to core functions label Aug 16, 2017
amcdnl added a commit to amcdnl/material2 that referenced this issue Sep 24, 2017
@amcdnl amcdnl closed this as completed Dec 2, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Development

No branches or pull requests

3 participants