Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

md-tab-body height doesn't collapse height properly #570

Closed
RoxKilly opened this issue May 29, 2016 · 3 comments · Fixed by #641
Closed

md-tab-body height doesn't collapse height properly #570

RoxKilly opened this issue May 29, 2016 · 3 comments · Fixed by #641

Comments

@RoxKilly
Copy link

RoxKilly commented May 29, 2016

Consider the following template:

<md-tab-group>
  <md-tab>
    <template md-tab-label>Label</template>
    <template md-tab-content>
      Any object shorter than 199px
    </template>
  </md-tab>
</md-tab-group>
<div>footer text</div>

The generated html puts the tab contents inside a <div class="md-tab-body">. Problem is that this div is always at least 199px in height. This poses problems when my content is meant to take very little height in the browser positioning logic. In the example above, notice how much blank space there is between the content and the footer

15

My specific user case is that within the tab pane I have a content-div whose aspect ratio needs to remain fixed. I've been using the solution from this post. It has been working well until I attempted to put the content in the new md-tab directive. Now, the bottom padding of the container-div no longer respects the limit set in CSS padding-bottom rule and I can't figure out why.

@jelbourn
Copy link
Member

@robertmesserle is this the expected behavior?

@sendilkumarn
Copy link
Contributor

Also why the default min height is set to 200px for tabs and 48 px for heading?

Shouldn't it be auto rather?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants