Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make expansion panel height configurable #5641

Closed
jbojcic1 opened this issue Jul 10, 2017 · 4 comments · Fixed by #6643
Closed

Make expansion panel height configurable #5641

jbojcic1 opened this issue Jul 10, 2017 · 4 comments · Fixed by #6643
Assignees
@crisbeto
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@jbojcic1
Copy link
Contributor

Bug, feature request, or proposal:

Proposal

What is the expected behavior?

Height of the md-expansion-panel-header should be configurable.

What is the current behavior?

Currently there is no way of doing it. I can only override it in css with important but then there is no animation.

What are the steps to reproduce?

Open material demo app and see expansion panel header.

What is the use-case or motivation for changing an existing behavior?

Custom header height.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

All

Is there anything else we should know?
@agustinhaller
Copy link

agustinhaller commented Aug 16, 2017 •
edited
Loading

I'm facing the same issue, any news about this?

ref: https://github.com/angular/material2/blob/73c6d8d75712ed32cee2b624356d191662f2553e/src/lib/expansion/expansion-panel-header.ts#L67-L68

@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Aug 23, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Aug 25, 2017
@crisbeto
feat(expansion-panel): allow for the panel header height to be custom…
8d5edfe 
…ized

Uses the new Angular animations features, that allow for dynamic values to be passed to an animation, to let consumers customize the `md-expansion-panel-header` height.

Fixes angular#5641.
@crisbeto crisbeto mentioned this issue Aug 25, 2017
Merged
jelbourn pushed a commit that referenced this issue Aug 30, 2017
@crisbeto @jelbourn
feat(expansion-panel): allow for the panel header height to be custom…
9eabda8 
…ized

Uses the new Angular animations features, that allow for dynamic values to be passed to an animation, to let consumers customize the `md-expansion-panel-header` height.

Fixes #5641.
jelbourn pushed a commit that referenced this issue Sep 1, 2017
@crisbeto @jelbourn
feat(expansion-panel): allow for the panel header height to be custom…
11e2239 
…ized (#6643)

Uses the new Angular animations features, that allow for dynamic values to be passed to an animation, to let consumers customize the `md-expansion-panel-header` height.

Fixes #5641.
@crisbeto crisbeto mentioned this issue Sep 14, 2017
Closed
@ghd8 ghd8 mentioned this issue Sep 20, 2017
Closed
@charlie-elverson charlie-elverson mentioned this issue Nov 8, 2017
Closed
@TqrHsn
Copy link

TqrHsn commented Dec 26, 2017

<mat-expansion-panel-header [expandedHeight]="48px">
gives:
snip_20171227005507

<mat-expansion-panel-header [expandedHeight]="48">
gives:
snip_20171227005610

unable to use this. Am I missing something?

@crisbeto
Copy link
Member

Your first example is invalid @TqrHsn. You should use [expandedHeight]="'48px'" or expandedHeight="48px".

@atluriajith atluriajith mentioned this issue Jan 3, 2018
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(expansion-panel): allow for the panel header height to be customized crisbeto/material2
5 participants
@agustinhaller @jelbourn @crisbeto @jbojcic1 @TqrHsn