Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focused md-select placeholder/label required * is not accent colour #5496

Closed
mtpultz opened this issue Jul 4, 2017 · 2 comments · Fixed by #5498
Closed

Focused md-select placeholder/label required * is not accent colour #5496

mtpultz opened this issue Jul 4, 2017 · 2 comments · Fixed by #5498
Assignees
@devversion
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@mtpultz
Copy link

mtpultz commented Jul 4, 2017 •
edited
Loading

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Label text and * should be primary then accent colour

What is the current behavior?

Label and * are both primary colour, unlike md-input fields

What are the steps to reproduce?

Add a select directly out of the docs with a required property, focus on the field and select an option, and * will be primary theme colour and not accent

Providing a Plunker (or similar) is the best way to get the team to see your issue.
http://plnkr.co/edit/Oy0TpVeCi4jxSSPGeV6c?p=preview

What is the use-case or motivation for changing an existing behavior?

Consistency

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular 4.2.5, Angular Material 2.0.0-beta.7, Windows 10
@mtpultz mtpultz changed the title Focused md-select placeholder/label required * is not accent Focused md-select placeholder/label required * is not accent colour Jul 4, 2017
@devversion devversion self-assigned this Jul 4, 2017
devversion added a commit to devversion/material2 that referenced this issue Jul 4, 2017
@devversion
fix(select): required asterisk should use warn color
ec4a901 
* When the select is focused and is also required, the asterisk of the select should use the accent palette. Similar to the Material Design input specifications.

Fixes angular#5496
@devversion devversion mentioned this issue Jul 4, 2017
Merged
@kara kara added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Jul 5, 2017
mmalerba pushed a commit that referenced this issue Jul 7, 2017
@devversion @mmalerba
fix(select): required asterisk should use warn color
751314a 
* When the select is focused and is also required, the asterisk of the select should use the accent palette. Similar to the Material Design input specifications.

Fixes #5496
@Knoxvillekm
Copy link

You can still add md-error?

mmalerba pushed a commit that referenced this issue Jul 9, 2017
@devversion @mmalerba
fix(select): required asterisk should use warn color (#5498)
97494f7 
* When the select is focused and is also required, the asterisk of the select should use the accent palette. Similar to the Material Design input specifications.

Fixes #5496
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(select): required asterisk should use warn color devversion/material2
4 participants
@mtpultz @kara @devversion @Knoxvillekm