Invalid font CSS for mat-input-container class #5262
Assignees
Labels
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Comments
jelbourn
added
the
P3
|
Will be fixed by #5154. |
crisbeto
added a commit
to crisbeto/material2
that referenced
this issue
Jun 21, 2017
Fixes the `font` declaration on the `md-input-container` being ignored, because it was invalid. Note: I updated the font size to the correct value from [the spec](https://material.io/guidelines/components/text-fields.html#text-fields-states), however I'm not using it, in order to avoid any breaking changes. Also note that since the line height wasn't being used before, the baseline is now slightly off when next to a select. Fixes angular#5262.
mmalerba
pushed a commit
that referenced
this issue
Jul 6, 2017
Fixes the `font` declaration on the `md-input-container` being ignored, because it was invalid. Note: I updated the font size to the correct value from [the spec](https://material.io/guidelines/components/text-fields.html#text-fields-states), however I'm not using it, in order to avoid any breaking changes. Also note that since the line height wasn't being used before, the baseline is now slightly off when next to a select. Fixes #5262.
jelbourn
pushed a commit
that referenced
this issue
Jul 14, 2017
Fixes the `font` declaration on the `md-input-container` being ignored, because it was invalid. Note: I updated the font size to the correct value from [the spec](https://material.io/guidelines/components/text-fields.html#text-fields-states), however I'm not using it, in order to avoid any breaking changes. Also note that since the line height wasn't being used before, the baseline is now slightly off when next to a select. Fixes #5262.
kara
pushed a commit
that referenced
this issue
Jul 21, 2017
Fixes the `font` declaration on the `md-input-container` being ignored, because it was invalid. Note: I updated the font size to the correct value from [the spec](https://material.io/guidelines/components/text-fields.html#text-fields-states), however I'm not using it, in order to avoid any breaking changes. Also note that since the line height wasn't being used before, the baseline is now slightly off when next to a select. Fixes #5262.
andrewseguin
pushed a commit
that referenced
this issue
Jul 24, 2017
Fixes the `font` declaration on the `md-input-container` being ignored, because it was invalid. Note: I updated the font size to the correct value from [the spec](https://material.io/guidelines/components/text-fields.html#text-fields-states), however I'm not using it, in order to avoid any breaking changes. Also note that since the line height wasn't being used before, the baseline is now slightly off when next to a select. Fixes #5262.
andrewseguin
pushed a commit
that referenced
this issue
Jul 25, 2017
Fixes the `font` declaration on the `md-input-container` being ignored, because it was invalid. Note: I updated the font size to the correct value from [the spec](https://material.io/guidelines/components/text-fields.html#text-fields-states), however I'm not using it, in order to avoid any breaking changes. Also note that since the line height wasn't being used before, the baseline is now slightly off when next to a select. Fixes #5262.
andrewseguin
pushed a commit
that referenced
this issue
Jul 26, 2017
Fixes the `font` declaration on the `md-input-container` being ignored, because it was invalid. Note: I updated the font size to the correct value from [the spec](https://material.io/guidelines/components/text-fields.html#text-fields-states), however I'm not using it, in order to avoid any breaking changes. Also note that since the line height wasn't being used before, the baseline is now slightly off when next to a select. Fixes #5262.
|
While the invalid CSS problem is fixed, the problematic behavior is not. Font size is still inherited which is not correct unless parent element font size happens to be defined as 16, which in most circumstances is unlikely. Material Design specifies that the font size be 16, so inherit is wrong. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Bug, feature request, or proposal:
Bug
What is the expected behavior?
font CSS style for .mat-input-container should be valid
What is the current behavior?
Default typography theme set
which both Firefox and Chrome developer tools show as invalid (the inherit value for font-size). So all Input fields are not correctly font styled, only if a parent is (for example body).
What are the steps to reproduce?
Check https://material.angular.io/components/input/examples and go to the inspector and notice the invalid CSS
What is the use-case or motivation for changing an existing behavior?
To have correct default Roboto fonts styles on input field without depending on body styles like beta 6 did
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Material beta 7
Is there anything else we should know?
The text was updated successfully, but these errors were encountered: