Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all components export a MD_XXX_DIRECTIVES constant #513

Closed
jelbourn opened this issue May 24, 2016 · 2 comments · Fixed by #514
Closed

Make all components export a MD_XXX_DIRECTIVES constant #513

jelbourn opened this issue May 24, 2016 · 2 comments · Fixed by #514
Labels
help wanted The team would appreciate a PR from the community to address this issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Milestone
alpha.6

Comments

@jelbourn
Copy link
Member

All of the components should include an export for a MD_XXX_DIRECTIVES constant (e.g., `MD_BUTTON_DIRECTIVES). This will make all of the imports / directive lists consistent.
@jelbourn jelbourn added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent effort1: easy (hours) help wanted The team would appreciate a PR from the community to address this issue labels May 24, 2016
@jelbourn jelbourn added this to the alpha.6 milestone May 24, 2016
@robertmesserle robertmesserle mentioned this issue May 24, 2016
Merged
jelbourn pushed a commit that referenced this issue May 25, 2016
@robertmesserle @jelbourn
fix(): adds directive constants to all components (#514)
fb89d4f 
closes #513
@billfranklin
Copy link

Was just coming here to request this. Thanks

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted The team would appreciate a PR from the community to address this issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
alpha.6
Development

Successfully merging a pull request may close this issue.

fix(): adds directive constants to all components
3 participants
@robertmesserle @jelbourn @billfranklin